commit | 0244ceee55df5ed87cfbccd8904a7daecb87c535 | [log] [tgz] |
---|---|---|
author | Sanika Kulkarni <sanikak@google.com> | Tue Mar 30 22:41:52 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Mar 30 22:41:52 2021 |
tree | 8dd476be34c7d13c76c0c2d3e50d885ff0069894 | |
parent | 510814163ea932f4d12abf1eb2480cae4f151f6f [diff] |
[conf-creator] set x-forwarded-host to virtual ip in nginx.conf The fake_omaha RPC depends on the X-Forwarded-Host header to function correctly. Change this to the Virtual IP so that the requests generated from fake_omaha are redirected correctly. BUG=chromium:1066608 TEST=Deployed on LTL k8s cluster. Change-Id: I5ce4555987f2f2b44266820540893d4a97af9434 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2787266 Auto-Submit: Sanika Kulkarni <sanikak@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> Reviewed-by: Congbin Guo <guocb@chromium.org> Commit-Queue: Sanika Kulkarni <sanikak@chromium.org> Cr-Commit-Position: refs/heads/master@{#39789}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.