commit | 029dc5666f102091950f645ef9023be7b32d4ba3 | [log] [tgz] |
---|---|---|
author | Mike Wittman <wittman@chromium.org> | Tue Jan 15 17:59:18 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Jan 15 17:59:18 2019 |
tree | 8d5aefda1e575bab893c1dbd89a134442f8c5063 | |
parent | 9bd27cf64264b645d6793b3380be18921c87e217 [diff] |
Revert "[Sampling profiler] Record continued_work sample metadata for Windows" This reverts commit 721cd487021616e86b84dab9ce27343ea65322e2. Reason for revert: ThreadProfiler outlives the main MessageLoop in the GPU and renderer processes, resulting in UAFs accessing the work id in the former and access to a stale stack location in the latter. Original change's description: > [Sampling profiler] Record continued_work sample metadata for Windows > > Records work ids along with samples to distinguish which samples came > from which work items (i.e. tasks, user interface event handlers, etc.) > This information will be used to infer coarse work item durations and > from that information, jankiness. > > Task id recording takes place while the thread is suspended so must > be implemented in a lockless fashion. > > The corresponding Mac implementation will be much more involved so is > deferred to a future CL. > > Bug: 851163 > Change-Id: I930773de320cb0ce02509c0dd222754722fac2bf > Reviewed-on: https://chromium-review.googlesource.com/c/1372829 > Commit-Queue: Mike Wittman <wittman@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#622632} TBR=wittman@chromium.org,fdoray@chromium.org Change-Id: I586da93bec9ad34b37d1218df72a82654a16bb42 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851163, 921952 Reviewed-on: https://chromium-review.googlesource.com/c/1412038 Reviewed-by: Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#622871}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .