Google Git
Sign in
chromium / infra / infra / 02ead66ed820206b3752865049c4268e179c2ee5
commit02ead66ed820206b3752865049c4268e179c2ee5[log] [tgz]
authorchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>Thu Apr 15 03:08:30 2021
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Apr 15 03:08:30 2021
tree87f03477fb5038abe935761df4ea41fd863b4091
parent89195e03f3314d1f8efc4644aa0640abad4ab6be [diff]
Roll luci-py from 7fb33784cc8d to 9c6dfb188013 (1 revision)

https://chromium.googlesource.com/infra/luci/luci-py.git/+log/7fb33784cc8d..9c6dfb188013

2021-04-15 momosasaki@google.com [swarming] make cmd_ver_out bytes in test_get_os_dims_mock*

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/luci-py-infra-autoroll
Please CC tikuta+infra-roll@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: tikuta+infra-roll@chromium.org
Change-Id: I5260931fa12477033bc23302016b2a9712e96bf9
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2827652
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#40175}
1 file changed
tree: 87f03477fb5038abe935761df4ea41fd863b4091
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. cipd/
  8. crdx/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. python_pb2/
  17. recipes/
  18. test/
  19. utils/
  20. .gitattributes
  21. .gitignore
  22. .style.yapf
  23. .yapfignore
  24. codereview.settings
  25. CONTRIBUTING.md
  26. DEPS
  27. LICENSE
  28. navbar.md
  29. OWNERS
  30. PRESUBMIT.py
  31. README.md
  32. run.py
  33. test.py
  34. WATCHLISTS
  35. WHITESPACE
README.md

infra.git repository

Testing Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications.
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.