Google Git
Sign in
chromium / infra / luci / recipes-py / 02f24140144c435c1c5cca1d1259257d3e6ba66c
commit02f24140144c435c1c5cca1d1259257d3e6ba66c[log] [tgz]
authorGarrett Beaty <gbeaty@chromium.org>Tue Apr 23 22:11:39 2019
committerCommit Bot <commit-bot@chromium.org>Tue Apr 23 22:11:39 2019
treec8f23d2f6594bbb0c5991f7a6e58542ddc61a8e2
parent2d211d498773f07ce6a37bb88a2464864eb3c841 [diff]
Update post_process_test.py to call magic_check_fn.post_process.

Manually constructing a checker and invoking post process hooks requires
changes to the test whenever the arguments for the checker or the types
expected to be passed to a hook change. Using post_process instead
limits the amount of changes that require updating all of the tests in
post_process_test.py to only those that change the public interface of
the magic_check_fn module.

Change-Id: I66f60cacf5be735cb8d525f5c3fdfc5e7d41c901
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1577825
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
1 file changed
tree: c8f23d2f6594bbb0c5991f7a6e58542ddc61a8e2
  1. doc/
  2. infra/
  3. misc/
  4. recipe_engine/
  5. recipe_modules/
  6. recipe_proto/
  7. recipes/
  8. unittests/
  9. .gitattributes
  10. .gitignore
  11. .vpython
  12. AUTHORS
  13. codereview.settings
  14. CONTRIBUTORS
  15. LICENSE
  16. OWNERS
  17. PRESUBMIT.py
  18. README.md
  19. README.recipes.md
  20. recipes.py
README.md

Recipes

Recipes are a domain-specific language (embedded in python) for specifying sequences of subprocess calls in a cross-platform and testable way.

Files

  • README.md

    This file!

  • doc/

    Documentation for the recipe engine (including this file!). See the design doc for more detailed design information about the recipe engine.

  • infra/

    Chrome infra config files.

  • recipes.py

    The main entry point to the recipe engine. It has many subcommands and flags; run recipes.py -h to see them. Include this in your repository to start using recipes.

  • recipes/

    Recipes in the recipe engine. These are either example recipes, or recipes which are used to test the engine (see run_test.py to see these run)

  • recipe_modules/

    Built in recipe modules. These are very useful when writing recipes; take a look in there, and look at each of their examples subfolders to get an idea how to use them in a recipe.

  • recipe_engine/

    The core functionality of the recipe engine. Noteworthy files include:

    • main.py -- The main entrypoint for the recipe engine.
    • recipes_cfg.proto -- The protobuf file which defines the format of a recipes.cfg file.
    • third_party/ -- third_party code which is vendored into the recipe engine.
    • recipe_api.py -- The api exposed to a recipe module.
    • unittests -- Unittests for the engine.

    There are also several files which correspond to a subcommand of recipes.py; run, and autoroll are some examples.

  • unittests/

    Somewhat poorly named, these are higher level integration tests.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.

Run the following to setup the code review tool and create your first review:

git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"
git checkout -b work origin/master

# hack hack

git commit -a -m "This is awesome"
# This will ask for your Google Account credentials.
git cl upload -s -r joe@example.com
# Wait for approval over email.
# Click "Submit to CQ" button or ask reviewer to do it for you.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.