Google Git
Sign in
chromium / chromium / src / 03089e2445101e1a2dce3b89262abfdb107def6f
commit03089e2445101e1a2dce3b89262abfdb107def6f[log] [tgz]
authorXi Han <hanxi@google.com>Fri Dec 07 01:15:25 2018
committerCommit Bot <commit-bot@chromium.org>Fri Dec 07 01:15:25 2018
treea8f368dc1d906c39396edc1cc2fa11a703b05f82
parent8e1e2d94aa4b3a81993943ac762d6ae0ef585e7c [diff]
Fix org.chromium.content.browser.BrowserStartupControllerTest failures on Android.

The crash is caused due to junit test BrowserStartupControllerTest doesn't
initialize the native but call serviceManagerStartupComplete. In that function,
we record startup metrics and failed due to native doesn't initialized. Therefore,
we add a protect function for the metrics record and override it in the
TestBrowserStartupController.

Bug: 912619
Change-Id: Ifa6ba36bc926f0f033f7df0f4e6a67fce0ca340f
Reviewed-on: https://chromium-review.googlesource.com/c/1366717
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614537}
2 files changed
tree: a8f368dc1d906c39396edc1cc2fa11a703b05f82
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .