Google Git
Sign in
chromium / external / github.com / luci / recipes-py / 044dba0634a396fd78f97f0f633136420780fc37
commit044dba0634a396fd78f97f0f633136420780fc37[log] [tgz]
authordnj <dnj@chromium.org>Fri Sep 23 01:53:09 2016
committerCommit bot <commit-bot@chromium.org>Fri Sep 23 01:53:09 2016
tree207373df087f5f243b53dd0ed19b192bece2a5c3
parent5b64ce6370b70afd63e463ae72f02e69ecc034ec [diff]
More strategic retries in fetch.

Define a generic conditional exponential backoff retry decorator.
Reimplement the content in fetch to use this decorator instead of
"_retry". Move decorator usage to the specific site of retryable failure
and only retry known-retryable errors so we don't waste time on failures.

This also adds a retry to Gitiles JSON fetching and a unit test to
assert that this retry logic works successfully.

Defines GitilesFetchError, which includes the status code and error text
ain the output message.

BUG=chromium:649529,chromium:649466
TEST=unit

Review-Url: https://codereview.chromium.org/2362993002
3 files changed
tree: 207373df087f5f243b53dd0ed19b192bece2a5c3
  1. bootstrap/
  2. doc/
  3. go/
  4. infra/
  5. misc/
  6. recipe_engine/
  7. recipe_modules/
  8. recipes/
  9. unittests/
  10. .gitignore
  11. AUTHORS
  12. codereview.settings
  13. CONTRIBUTORS
  14. LICENSE
  15. OWNERS
  16. PRESUBMIT.py
  17. README.md
  18. recipes.py
README.md

Recipes

Recipes are a domain-specific language (embedded in python) for specifying sequences of subprocess calls in a cross-platform and testable way.

Files

  • README.md

    This file!

  • bootstrap/

    Bootstrapping and vendoring related code.

  • doc/

    Documentation for the recipe engine (including this file!). Also includes doc/recipes.py, which is a file you can include in your repository to start using recipes. See the design doc for more detailed design information about the recipe engine.

  • infra/

    Chrome infra config files.

  • recipes.py

    The main entry point to the recipe engine. It has many subcommands and flags; run recipes.py -h to see them.

  • recipes/

    Recipes in the recipe engine. These are either example recipes, or recipes which are used to test the engine (see run_test.py to see these run)

  • recipe_modules/

    Built in recipe modules. These are very useful when writing recipes; take a look in there, and look at their example.py files.

  • recipe_engine/

    The core functionality of the recipe engine. Noteworthy files include:

    • package.proto -- The protobuf file which defines the format of a recipes.cfg file.
    • third_party/ -- third_party code which is vendored into the recipe engine.
    • recipe_api.py -- The api exposed to a recipe module.
    • unittests -- Unittests for the engine.

    There are also several files which correspond to a subcommand of recipes.py; depgraph, run, and autoroll are some examples.

  • unittests/

    Somewhat poorly named, these are higher level integration tests.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.

Run the following to setup the code review tool and create your first review:

git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"
git checkout -b work origin/master

# hack hack

git commit -a -m "This is awesome\nR=joe@example.com"
# This will ask for your Google Account credentials.
git cl upload -s
# Wait for LGTM over email.
# Check the commit queue box in codereview website.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.