commit | 048f05489b0cd7e017adf8671f45267e39f4798d | [log] [tgz] |
---|---|---|
author | Dirk Pranke <dpranke@google.com> | Tue Aug 11 18:14:18 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Aug 11 18:14:18 2020 |
tree | 9b580334c7c7665346171ebf1f2d2b608d3bf815 | |
parent | 40439456d3113bd42b514005c9b255baf107ba93 [diff] |
Switch to passing command lines via an isolated file. It turns out that passing command lines via builder properties causes the command line that kitchen uses to run a chromium recipe to exceed 32k (the max) on Windows. So, this CL switches to passing command lines from builder to tester via a file uploaded and downloaded from the isolate server; this should be quite robust. [ This is option 2B from https://docs.google.com/document/d/1UA-3h2Mmqr3BqfEfLFubveFJIk_52T9sBFgC7MShPJ4/edit?usp=sharing ]. Bug: 1108005 Change-Id: I4e823ff3d6f4f73d0af643246b641d75f79c69ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2347247 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*
), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores
, with the exception of the special functions RunSteps
and RunTests
in recipes. Use yapf (git cl format
) to autoformat new code.