Switch to passing command lines via an isolated file.

It turns out that passing command lines via builder properties
causes the command line that kitchen uses to run a chromium recipe to
exceed 32k (the max) on Windows.

So, this CL switches to passing command lines from builder to
tester via a file uploaded and downloaded from the isolate server;
this should be quite robust.

[ This is option 2B from
https://docs.google.com/document/d/1UA-3h2Mmqr3BqfEfLFubveFJIk_52T9sBFgC7MShPJ4/edit?usp=sharing ].

Bug: 1108005
Change-Id: I4e823ff3d6f4f73d0af643246b641d75f79c69ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2347247
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
11 files changed
tree: 9b580334c7c7665346171ebf1f2d2b608d3bf815
  1. infra/
  2. scripts/
  3. site_config/
  4. third_party/
  5. .gitattributes
  6. .gitignore
  7. .style.yapf
  8. .vpython
  9. .yapfignore
  10. codereview.settings
  11. CROS_OWNERS
  12. DEPS
  13. environment.cfg.py
  14. LICENSE
  15. OWNERS
  16. PRESUBMIT.py
  17. README.md
  18. WATCHLISTS
README.md

Recipes

If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format) to autoformat new code.