commit | 057831ef1f149883e3c26f58a867663f78dc49e1 | [log] [tgz] |
---|---|---|
author | Haiyang Pan <hypan@google.com> | Sat Apr 10 00:11:10 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Sat Apr 10 00:11:10 2021 |
tree | bf37d468d8b8725ad41cc2feb8aff4450bf74344 | |
parent | b2c07b2300438244429333d5fb42248442985850 [diff] |
Recipe: Add timeout for fetching gerrit commit message in tryserver API In crbug.com/1196159, a build got stuck at "gerrit changes" step for 3 hours. It would be good to add a timeout so that it fails early. Also adjust the timeout for get_changes to 60s, from 600s Bug: 1196159 Change-Id: Id2327ab40dd2fd8d95aaad6bb724f7ed06e6c244 Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: build Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2811899 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.