Revert of Switch media stream permissions to use IsOriginSecure() instead of SchemeIsSecure(). (patchset #11 id:220001 of https://codereview.chromium.org/1132203002/ )
Reason for revert:
This CL broke WebRtcWebcamBrowserTest.TestAcquiringAndReacquiringWebcam on all platforms, failing on the introduced assert 'EXPECT_TRUE(permissionRequestObserver.request_shown());’ at webrtc_browsertest_base.cc:149.
Link to bots:
https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester
https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester
Stdio output:
[ RUN ] WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.TestAcquiringAndReacquiringWebcam/0
[7391:1799:0807/160702:WARNING:vt_video_decode_accelerator.cc(194)] Failed to initialize VideoToolbox framework. Hardware accelerated video decoding will be disabled.
[7388:1799:0807/160703:INFO:CONSOLE(71)] "This appears to be Chrome", source: http://127.0.0.1:50232/webrtc/adapter.js (71)
[7388:71959:0807/160703:WARNING:embedded_test_server.cc(258)] Request not handled. Returning 404: /favicon.ico
[7388:1799:0807/160703:INFO:CONSOLE(13)] "Returning has-video-input-device to test.", source: http://127.0.0.1:50232/webrtc/test_functions.js (13)
[7388:1799:0807/160703:INFO:CONSOLE(13)] "Requesting doGetUserMedia: constraints: {"video":{"mandatory":{"minWidth":640,"maxWidth":640,"minHeight":480,"maxHeight":480}}}", source: http://127.0.0.1:50232/webrtc/test_functions.js (13)
[7388:1799:0807/160703:INFO:CONSOLE(13)] "Returning request-callback-granted to test.", source: http://127.0.0.1:50232/webrtc/test_functions.js (13)
[7388:1799:0807/160703:INFO:CONSOLE(13)] "Returning ok-got-stream to test.", source: http://127.0.0.1:50232/webrtc/test_functions.js (13)
[7388:1799:0807/160703:INFO:CONSOLE(13)] "Returning ok-started to test.", source: http://127.0.0.1:50232/webrtc/test_functions.js (13)
[7388:1799:0807/160703:INFO:CONSOLE(13)] "Returning video-not-playing to test.", source: http://127.0.0.1:50232/webrtc/test_functions.js (13)
[7388:1799:0807/160703:INFO:CONSOLE(13)] "Returning video-playing to test.", source: http://127.0.0.1:50232/webrtc/test_functions.js (13)
[7388:1799:0807/160703:INFO:CONSOLE(13)] "Returning ok-640x480 to test.", source: http://127.0.0.1:50232/webrtc/test_functions.js (13)
[7388:1799:0807/160704:INFO:CONSOLE(13)] "Returning ok-stopped to test.", source: http://127.0.0.1:50232/webrtc/test_functions.js (13)
[7388:1799:0807/160704:INFO:CONSOLE(13)] "Requesting doGetUserMedia: constraints: {"video":{"mandatory":{"minWidth":640,"maxWidth":640,"minHeight":360,"maxHeight":360}}}", source: http://127.0.0.1:50232/webrtc/test_functions.js (13)
[7388:1799:0807/160704:INFO:CONSOLE(13)] "Returning request-callback-granted to test.", source: http://127.0.0.1:50232/webrtc/test_functions.js (13)
../../chrome/browser/media/webrtc_browsertest_base.cc:149: Failure
Value of: permissionRequestObserver.request_shown()
Actual: false
Expected: true
[7388:1799:0807/160704:INFO:CONSOLE(13)] "Returning ok-got-stream to test.", source: http://127.0.0.1:50232/webrtc/test_functions.js (13)
[7388:1799:0807/160704:INFO:CONSOLE(13)] "Returning ok-started to test.", source: http://127.0.0.1:50232/webrtc/test_functions.js (13)
[7388:1799:0807/160704:INFO:CONSOLE(13)] "Returning video-not-playing to test.", source: http://127.0.0.1:50232/webrtc/test_functions.js (13)
[7388:1799:0807/160704:INFO:CONSOLE(13)] "Returning video-playing to test.", source: http://127.0.0.1:50232/webrtc/test_functions.js (13)
[7388:1799:0807/160704:INFO:CONSOLE(13)] "Returning ok-640x360 to test.", source: http://127.0.0.1:50232/webrtc/test_functions.js (13)
[7388:1799:0807/160704:INFO:CONSOLE(13)] "Returning ok-stopped to test.", source: http://127.0.0.1:50232/webrtc/test_functions.js (13)
[ FAILED ] WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.TestAcquiringAndReacquiringWebcam/0, where GetParam() = "force-qtkit" (2127 ms)
Original issue's description:
> Switch media stream permissions to use IsOriginSecure() instead of
> SchemeIsSecure().
>
> In particular, note that this means that media permissions are persisted on http://localhost.
>
> The change also updates the old media stream permission tests (which
> were no longer testing anything meaningful).
>
> BUG=295723, 362214, 509844
>
> Committed: https://crrev.com/2249c80e8c4b50793a8261c4f9eb3f879ddf4aff
> Cr-Commit-Position: refs/heads/master@{#342458}
TBR=felt@chromium.org,raymes@chromium.org,tommi@chromium.org,lgarron@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=295723, 362214, 509844
Review URL: https://codereview.chromium.org/1276373004
Cr-Commit-Position: refs/heads/master@{#342562}
7 files changed
