commit | 05e3dabf1e5482156dbdcba25c3490599f1591ad | [log] [tgz] |
---|---|---|
author | John Budorick <jbudorick@chromium.org> | Wed Jun 13 16:54:24 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jun 13 16:54:24 2018 |
tree | bd16f87fd1976dcfe141c470b26282e425c8661b | |
parent | bb67bf56b4b5d4cb0a32b8376eee5e740db220d3 [diff] |
Revert "[Mac] Created Suggested Text Touch Bar" This reverts commit b0bedb93eb732486e3701f3de0d11a3164d9ea79. Reason for revert: Seemingly causing interactive_ui_tests failures. Original change's description: > [Mac] Created Suggested Text Touch Bar > > When text is selected in a textfield, the touch bar displays options > to replace the selected text. Clicking on one of the options will > replace the selected text with the selected option. > > Currently, there are no functional unit tests for the suggested text > touch bar. As functionality is fleshed out, unit tests will be > created. > > A new folder (chrome/browser/ui/cocoa/touchbar) was created to house all > files related to the Mac touch bar. The > CreditCardAutofillTouchBarController files and the > WebTextfieldTouchBarController files were moved to this new folder. > Dependencies and header guards were updated to reflect this change. > > New files: > - suggested_text_touch_bar_controller.h > - suggested_text_touch_bar_controller.mm > - suggested_text_touch_bar_controller_browsertest.mm > Moved files: > - credit_card_autofill_touch_bar_controller.h > - credit_card_autofill_touch_bar_controller.mm > - credit_card_autofill_touch_bar_controller_unittest.mm > - web_textfield_touch_bar_controller.h > - web_textfield_touch_bar_controller.mm > > BUILD files were updated to accomodate the change in location for the > moved files and to include the new files. > > WebContentsImpl, WebContentsDelegate, and WebContentsObserver were > modified so that the SuggestedTextTouchBarController can observe > TextInputManager for a change in text selection. > > A feature flag SuggestedTextTouchBar was created and added to > chrome://about so that the new touch bar is disabled by default and > can be enabled via command line or chrome://flags with the flag > #enable-suggested-text-touch-bar. > > This CL includes the following browser tests for > SuggestedTextTouchBarController: > - SetTextTest > - TouchBarTest > - TextSelectionChangedTest > > Bug: 717553 > Change-Id: Iddba71339a3631a1405a37e461020345f921f817 > Reviewed-on: https://chromium-review.googlesource.com/1096443 > Commit-Queue: Tessa Nijssen <tnijssen@google.com> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Sarah Chan <spqchan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566539} TBR=avi@chromium.org,spqchan@chromium.org,tnijssen@google.com Change-Id: I3e465dc39e486e8fa2a7ad4d8e4d4a03096a3ba0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 717553 Reviewed-on: https://chromium-review.googlesource.com/1099117 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#566876}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .