| commit | 061a2dcf8d72817b52b2957f7b643f5e2aa60c84 | [log] [tgz] |
|---|---|---|
| author | Yiwei Zhang <yiwzhang@google.com> | Wed Nov 18 18:12:29 2020 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Nov 18 18:12:29 2020 |
| tree | ee6213993bdaca4e7d19a534f37a7f1cca86211c | |
| parent | 2cc9f6a9eaab1d5c82cb3efd5b1cab85035b01af [diff] |
[luciexe] stop using FileObjectPOSIX when sending data to logdog butler
It looks like sometimes data is not sent to lodgog butler if the client (
i.e. a socket) is wrapped with FileObjectPOSIX. It could be a bug in the
gevent libray or I use it in a wrong way.
This is causing Build page to be blanket while recipe is running fine.
Therefore, ditch this feature completely because:
* Future module (parallel recipe) is not widely used so this feature
won't give us much performence gain.
* It is currently only enabled on POSIX, which means we will anyway
need to figure out a general solution that works for both platforms
in the future.
* If we implement go/butler-protocol-v2, it's likely we don't need it
at all because sending log become a plain http request.
R=tandrii
Bug: 1150172
Change-Id: I9300ed226f4e43441efaa35c5eaa0215785e4ff3
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/2546059
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Recipes are a domain-specific language (embedded in Python) for specifying sequences of subprocess calls in a cross-platform and testable way.
They allow writing build flows which integrate with the rest of LUCI.
Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.
user.email and user.name are configured in git config.Run the following to setup the code review tool and create your first review:
# Get `depot_tools` in $PATH if you don't have it git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools export PATH="$PATH:$HOME/src/depot_tools" # Check out the recipe engine repo git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py # make your change cd $HOME/src/recipes-py git new-branch cool_feature # hack hack git commit -a -m "This is awesome" # This will ask for your Google Account credentials. git cl upload -s -r joe@example.com # Wait for approval over email. # Click "Submit to CQ" button or ask reviewer to do it for you. # Wait for the change to be tested and landed automatically.
Use git cl help and git cl help <cmd> for more details.