Google Git
Sign in
chromium / chromium / src / 06c20788cc532a7565c4004b17789ba409751de1
commit06c20788cc532a7565c4004b17789ba409751de1[log] [tgz]
authorVaclav Brozek <vabr@chromium.org>Wed Dec 06 11:12:26 2017
committerCommit Bot <commit-bot@chromium.org>Wed Dec 06 11:12:26 2017
tree025108a9bcc3a5a9c8706dc8d55cda3e8a3c1394
parente184205c9a927794bf60dcaff57013c1a9036d76 [diff]
[Android passwords settings] Add reauthentication for export

Mocks: go chrome-pwd-export-mocks-android (Google-internal only)

Screencast after the change: https://crbug.com/788701#c3

The CL adds a reauthentication step before the user can trigger
exporting passwords.

In addition to that, the CL also wraps the check for screen lock
availability in ReauthenticationManager.isScreenLockSetUp, to
make it possible to override for testing.

Also, this CL adds two tests for viewing passwords, because one
of earlier iterations of this CL broke something for the viewing
passwords feature and such tests would have caught it.

Bug: 788701
Change-Id: Ibfa37192e26bc5797236ba9378aa1eb0f17f79cc
Reviewed-on: https://chromium-review.googlesource.com/797453
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522061}
6 files changed
tree: 025108a9bcc3a5a9c8706dc8d55cda3e8a3c1394
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .