commit | 074fa51f85b15ad2e2d6c804a03825d48dbeb063 | [log] [tgz] |
---|---|---|
author | Hans Wennborg <hans@chromium.org> | Mon Sep 18 19:43:09 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Sep 18 19:43:09 2017 |
tree | 47461a1305e58000b7311cfdb4189e88f99cfce4 | |
parent | 9a756143491707b8319890b00fde33394fdbe4ff [diff] |
Reland "Clang: enable -instcombine-lower-dbg-declare=1" Trying harder to exclude CrOS build configs that don't use Chromium's Clang. Note to CrOS folks: If this breaks build configs that are not tested upstream, please ping me and/or llozano before reverting. This is a reland of 32750c1251012624a87fb97098bd0f6a60ffa8ed Original change's description: > Clang: enable -instcombine-lower-dbg-declare=1 > > This enables better optimized debug info for address-taken values > at the cost of potentially inaccurate debug info in some situations. > > We believe turning this on is the right trade-off for developers > debugging Chromium on all platforms, but especially on Windows where > values that are available in MSVC's debug info would otherwise show > as unavailable when using Clang. > > The goal (crbug.com/765793) is to make Clang's optimized > debug info good enough in all cases that this compromise is not > necessary. > > Note: This requires Clang r313108 or later. > > Bug: 761633, 753736, 765793 > Change-Id: Ia0ed38c499fac282a3c8ab27c5fd5571fdfab84d > Reviewed-on: https://chromium-review.googlesource.com/669314 > Commit-Queue: Hans Wennborg <hans@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#502428} TBR=thakis Bug: 761633, 753736, 765793 Change-Id: I2c3670873f1bd1d75cf1c41191b170983f41e0d0 Reviewed-on: https://chromium-review.googlesource.com/671523 Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#502646}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .