commit | 077374eafc3252db5df33395650a01758cf4c16b | [log] [tgz] |
---|---|---|
author | Thiemo Nagel <tnagel@chromium.org> | Fri Oct 06 11:15:59 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Oct 06 11:15:59 2017 |
tree | b0f51516e01be774c3b96505f6786baba7f01838 | |
parent | 803eee4b8808356d481aa30431e2234aced8b16e [diff] |
Revert "[LayoutNG] Handle 'auto' for new formatting contexts within a BFC." This reverts commit 66ac041a68867bba038144fa82d5b91d7ca55e19. Reason for revert: Speculative revert due to webkit layout failures (execution timing). This is the only CL in the regression range that seems to affect webkit. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/11417 Original change's description: > [LayoutNG] Handle 'auto' for new formatting contexts within a BFC. > > This implements our current behaviour for 'auto' sized FCs within a BFC. > > We need to perform layout twice under two scenarios: > 1. 'auto' inline size child. In this case we need to perform layout > once, and if the child doesn't fit, we perform layout a second time > with an "open" layout opportunity, so we can guarantee it will fit. > > 2. Non-adjoining margin strut and unpositioned floats/current layout. > In this case we need to perform a relayout as the BFCOffset where > floats will be positioned will change. This happens if the child > doesn't fit on the "top" of the exclusion space. > > This also adds more TODOs everywhere which we can handle later. > I kept this as small as possible to keep sanity. :) > > Bug: 635619 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng > Change-Id: I499dc9722fac47f43694f35c507e9d2742d317db > Reviewed-on: https://chromium-review.googlesource.com/680176 > Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506963} TBR=dgrogan@chromium.org,eae@chromium.org,ikilpatrick@chromium.org Change-Id: I7ae90715128234656b6ed4a8b619a542c538a2e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/704854 Reviewed-by: Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#507030}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .