commit | 081fd44ad92323c8562b7f952f7eef8a61232505 | [log] [tgz] |
---|---|---|
author | Mounir Lamouri <mlamouri@chromium.org> | Mon Nov 26 20:13:25 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Nov 26 20:13:25 2018 |
tree | 3c9b85f0de88ccda0445a150c8121693b0c56ed7 | |
parent | a708cebe75587364b9692451c17c82137c100fc3 [diff] |
Revert "Reland "v8binding: Do not hold a cross origin ScriptState in IDL callback function"" This reverts commit 20b501c316f87203b461a6769f3d113711ecaa1e. Reason for revert: FindIt believe with 74% confidence that it's the cause of these failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9835 Original change's description: > Reland "v8binding: Do not hold a cross origin ScriptState in IDL callback function" > > This is a reland of 756bea38c853ce40e3daba7f7fadf85b0920785f > > Original change's description: > > v8binding: Do not hold a cross origin ScriptState in IDL callback function > > > > Make IDL callback function not hold a ScriptState of its > > creation context when it's cross origin from the incumbent > > realm. > > > > Not holding a cross origin ScriptState, there is much > > less risk to access a cross origin context. > > > > IDL callback interface will follow the same approach in > > a separate patch. > > > > Bug: 892755, 886588, 904218 > > Change-Id: Ie55b436fcc5f66f4ee053ef08ad98ea68fb3a2d6 > > Reviewed-on: https://chromium-review.googlesource.com/c/1314023 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#609662} > > Bug: 892755, 886588, 904218 > Change-Id: I78ca7050e659cdb533ae09dab792bc699d2b48bf > Reviewed-on: https://chromium-review.googlesource.com/c/1343881 > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610820} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org Change-Id: I21faed593e8bdaae31c86a11413b18d31ab38c45 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 892755, 886588, 904218 Reviewed-on: https://chromium-review.googlesource.com/c/1351424 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#610929}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .