commit | 08c0cf8984048bc5c40d01fc679c11b97c17e5a5 | [log] [tgz] |
---|---|---|
author | dpapad <dpapad@chromium.org> | Thu Nov 30 00:52:35 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Nov 30 00:52:35 2017 |
tree | daead08db7746285af3fddae50fc7db6584d7e4e | |
parent | 12b8d4ba28076fdfe6e947d3c18d0a95c70861fc [diff] |
MD Extensions polish: Update options dialog sizing logic. - Remove unwanted default paddings and border of cr-dialog. - Fix sizing logic to respect the user provided preferred values (with some constraints). - Simplify logic to size the options dialog, by using width: fit-content, (no need to use JS to calculate min-width for the title + icon). - Eliminate flicker (previously the dialog was re-sized twice). - Updated tests to use a real extension that specifies an options_ui in the manifest.json, to ensure that the onpreferredsizechanged logic works end-to-end. Bug: 787234 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic1e9b372c5889f08abc42cf1c460291b7b63062e Reviewed-on: https://chromium-review.googlesource.com/786084 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#520353}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .