commit | 09434a5bbbee5a2ebecd559aece3453beab669bb | [log] [tgz] |
---|---|---|
author | Tiffany Zhang <zhangtiff@google.com> | Tue Dec 22 18:36:48 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Dec 22 18:36:48 2020 |
tree | ecd66a7e93e1bd81c037bf18a01979c62d90a1d2 | |
parent | 3d5ef21ac76cf36e513c299b2f3574fbc9ca3f7a [diff] |
Monorail: Add UI warning when users try to download unrecognized attachment types. Demo: https://37147-3b7fa09-tainted-zhangtiff-ui-warning-dot-monorail-dev.appspot.com/p/chromium/issues/detail?id=908973#c12 Bug: monorail:8693 Change-Id: I4d456a8c7e1d5c83de341d4d48ebaf51e9a7bf16 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2598583 Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: Dave Tu <dtu@chromium.org> Cr-Commit-Position: refs/heads/master@{#37195}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.