commit | 09e0b38f0f512d257976c5a6b73845e47edd915a | [log] [tgz] |
---|---|---|
author | Nico Weber <thakis@chromium.org> | Mon Mar 11 16:54:07 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Mar 11 16:54:07 2019 |
tree | d8927384ee02164b52c92c8253ea420f0b261e9c | |
parent | 3485a263f4ab1f5e5576d0bd3b2633a37b8b217f [diff] |
Move gclient path access to separate module. gclient_utils.py is a kitchen sink and is for that reason expensive to import. Move the comparatively cheap and simple path routines to a new gclient_paths module and use that in gn.py, clang_format.py, dart_format.py. (To be able to move FindGclientRoot() to gclient_paths.py, make it use io.open() instead of FileRead(). FileRead() tries to paper over invalid utf-8, but that was added for presubmits, not for .gclient files, so this is hopefully fine.) Cuts gn.py overhead in half (on my Windows laptop from 0.6s to 0.25s, still high; on my Mac laptop from 0.1s to 0.05s), and probably helps the other two too. Completely remove PathDifference() since it's unused. Bug: 939959 Change-Id: I6a70f6e4c16062b622fb2df8778e8a598d4cc956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1512058 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.