[Download] Treat RESUMING_INTERNAL as IN_PROGRESS in DownloadItem.
The RESUMING_INTERNAL state is used to indicate that the DownloadItem
has commenced a resumption attempt. The DownloadItem will remain in this
state until the network request receives a response.
Formerly, we treated this internal state as INTERRUPTED for all entities
that are observing the download item, including the UI. However, in
retrospect, this doesn't make sense and prevents the DownloadItem from
cleanly handling cases where it needs to transition back to an
interrupted state following a resumption attempt. In the latter case,
the download would otherwise try to transition from INTERRUPTED ->
INTERRUPTED which doesn't make a whole lot of sense to an outside
observer.
In addition, keeping the download in the INTERRUPTED state prevents an
outside observer from being able to cleanly tell when a resumption
attempt has begun. Furthermore, the INTERRUPTED state exhibited while an
automatic resumption is being attempted is not actionable to all outside
observers.
To rectify these, this change makes the RESUMING_INTERNAL state be
visible to external observers as IN_PROGRESS.
BUG=7648
R=svaldez@chromium.org
Committed: https://crrev.com/ad29c15e3115a256cec6ee0ab0ba3138ef087569
Cr-Commit-Position: refs/heads/master@{#366542}
Reverted due to failure in XP bots.
Reverted: https://crrev.com/5a45da8d4a87ffc6100ab8b684f3ad2eaef639b4
Cr-Commit-Position: refs/heads/master@{#366574}
Review URL: https://codereview.chromium.org/1544653002
Cr-Commit-Position: refs/heads/master@{#366681}
3 files changed
