commit | 0d0cd2ae30aaac240ddb6cb6eb4914679643db0b | [log] [tgz] |
---|---|---|
author | Dirk Pranke <dpranke@google.com> | Thu Aug 13 23:26:40 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Aug 13 23:26:40 2020 |
tree | 7901c39e6e32eb617a7a30d58fcc5bbe637e12a9 | |
parent | a74187b9b975b37d72f78cd4954f32eca7222f13 [diff] |
Pass build directory from builder to tester. In switching builders to set the swarming command line directly, we had been relying on the tester having the same build directory configured as the builder (e.g., "out/Debug"). However, if you have a 64-bit builder running on Windows and a thin tester running on Linux, by default you'll build into "out/Release_x64" and try to use "out/Release" on the tester. We should've just been passing the build directory to use along with the other information on the command line, so as to not rely on this. This CL adds an additional build property, 'swarming_command_lines_cwd', to do that. Bug: 1116139, 1108005 Change-Id: I68d29532fa2acebfe12f5c1c27930ffe00926fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2354631 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*
), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores
, with the exception of the special functions RunSteps
and RunTests
in recipes. Use yapf (git cl format --no-clang-format
) to autoformat new code.