Google Git
Sign in
chromium / chromium / src / 0da801c32687733e8d0e043e42f621abac157df6
commit0da801c32687733e8d0e043e42f621abac157df6[log] [tgz]
authorLeonard Grey <lgrey@chromium.org>Fri Dec 14 15:07:25 2018
committerCommit Bot <commit-bot@chromium.org>Fri Dec 14 15:07:25 2018
tree2ba71c16776f448917f8513dd772f60816a04ce1
parent86b46190c5b00c75e4bd4a8597964d769a866df6 [diff]
Mac: Don't explicitly set high contrast appearances when forcing appearance

Despite these being perfectly kosher appearance names, the system returns
nil when you set them, which inadvertently turns on dark mode for high
contrast users if their system is in Mojave dark mode.

Since most of our high contrast interventions are at the views level,
regular Aqua appearance will do temporarily.

Bug: 913503
Change-Id: I13238eac68d2dfa4a0d4c828bdd3e98d37d0505a
Reviewed-on: https://chromium-review.googlesource.com/c/1374437
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616673}
3 files changed
tree: 2ba71c16776f448917f8513dd772f60816a04ce1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .