| commit | 0e40450f0980d1ae6aa1ab2150a065f4dd25a798 | [log] [tgz] |
|---|---|---|
| author | Vadim Shtayura <vadimsh@chromium.org> | Thu Dec 06 21:28:50 2018 |
| committer | Commit Bot <commit-bot@chromium.org> | Thu Dec 06 21:28:50 2018 |
| tree | 8f0b7c84c3c13a3f16c7befde8630408f79594d5 | |
| parent | 9d3688949727026d533af2086ceb91a558f3789f [diff] |
[lucicfg] Pattern matching for expected errors messages in tests. Now we can declare that a test is expected to emit an error like: Traceback (most recent call last): ... //testdata/errors_like.star:???: in func2 //testdata/errors_like.star:???: in capture_stack Error: ??? err And '...' will be matched to zero or more arbitrary lines and '???' to a word. This should make tests that examine errors much less brittle. R=nodir@chromium.org, tandrii@chromium.org BUG=833946 Change-Id: I2d978ff7df55d1291f92cee36bb6a7f7cc6bf4aa Reviewed-on: https://chromium-review.googlesource.com/c/1365130 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:
fetch infra cd infra/go eval `./env.py` cd src/go.chromium.org/luci
Contributing uses the same flow as Chromium contributions.