commit | 0e7c32a605f979176bfe86a4aafc394d045e627f | [log] [tgz] |
---|---|---|
author | Ovidio Henriquez <odejesush@chromium.org> | Wed Jan 16 03:15:29 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jan 16 03:15:29 2019 |
tree | 6b9031f8692fc4eacdcf8f34f3b3d8f056f8ec63 | |
parent | 22b59cde0c76db5687f51c3014661cdec7d14cc6 [diff] |
Use SettingSource for ChooserContextBase This change refactors the ChooserContextBase::Object class to accept a content_settings::SettingSource enum for the source, instead of a string. This change enables the Object class to also be used by PageInfoUI to distinguish between user and policy permissions by refactoring ChooserContextBase::GetGrantedObjects() to return list of unique_ptrs to the Object class. In addition, the DictionaryValue field of Object was renamed to `value` to make it easier to differentiate from Object. Design doc: https://docs.google.com/document/d/1MPvsrWiVD_jAC8ELyk8njFpy6j1thfVU5aWT3TCWE8w Bug: 854329 Change-Id: Ic320bf3709c464e5acc514cde7594aec90c1c7f6 Reviewed-on: https://chromium-review.googlesource.com/c/1399468 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Reviewed-by: Raymes Khoury <raymes@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#623079}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .