commit | 0eacfc877a26fcf93b142c367280296f4f8a2744 | [log] [tgz] |
---|---|---|
author | Congbin Guo <guocb@chromium.org> | Tue Apr 13 20:36:46 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Apr 13 20:36:46 2021 |
tree | 6d96269b4a15c9843f2385537471d3cad82b9177 | |
parent | 5111a653a00cea76ce42b76f63e6efdf00aafe89 [diff] |
tls: FakeOmaha: improvements 1. Respect the shebang in nebraska.py. 2. Dump Nebraska logs when closing it. 3. Increase the timeout to read port file to avoid flakiness on a loaded server. BUG=chromium:1189379 TEST=Ran FakeOmaha integration test. Change-Id: I6cc2559fbcf9964451bcc641e1a835f58e5ae2d1 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2823413 Auto-Submit: Congbin Guo <guocb@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> Commit-Queue: Allen Li <ayatane@chromium.org> Cr-Commit-Position: refs/heads/master@{#40128}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.