commit | 0eb06307382a59b1d66afa66703cdc95a2b7ca2e | [log] [tgz] |
---|---|---|
author | Manuel Rego Casasnovas <rego@igalia.com> | Tue Jan 23 21:29:40 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Jan 23 21:29:40 2018 |
tree | 260dc37a84f0a99110a873b7c59534875cd96f90 | |
parent | 692b3b47879c75c1321ec759cb10fdd3f59e9fcc [diff] |
[css-multicol] Support percentages in column-gap This patch adds percentage support to column-gap property. Most of the changes are related to the parsing logic, the column-gap property now accepts both length and percentages, on top of the "normal" initial value. A new utility class GapLength has been added, as it'll be useful to implement row-gap in the future. Apart from that the muticolumn layout code has been modified to resolve the percentage gaps (treating them as zero while computing preferred widths) and resolving them during layout. This doesn't follow the current text on the spec, but there is an ongoing discussion that might cause the text is changed: https://github.com/w3c/csswg-drafts/issues/509#issuecomment-355242101 We could update the implementation once we have a definitive answer from the CSS WG. Added a new WPT test to check the behavior under different sizing conditions. BUG=799413 TEST=external/wpt/css/css-multicol/multicol-gap-percentage-001.html Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Icccd046e913353b6f525481046a41ad125aea5ff Reviewed-on: https://chromium-review.googlesource.com/878199 Reviewed-by: meade_(do not use) <meade@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#531356}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .