commit | 0f4ea08c738b030656a74a3b837fdd833d20f308 | [log] [tgz] |
---|---|---|
author | Ian Kilpatrick <ikilpatrick@chromium.org> | Mon Nov 05 15:56:14 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Nov 05 15:56:14 2018 |
tree | 2de4e28d6c5b3127c56639fc11c210b1431f82fb | |
parent | ce2ed51a2723d95dc3a0289961f9ae95568d51fa [diff] |
[LayoutNG] Fix shape-outside-{circle-048,polygon-020}.html tests. This was two subtle bugs in one. 1) We need to copy back data to the ShapeOutsideInfo side data-structure, even if its an "intermediate" layout, (during the min/max pass). This was causing the incorrect size to be calculated for body, as it thought the shape was "empty" (its size was 0,0). Eventually this should be fixed by moving the shape to the layout result, removing this side data-structure. 2) The static-position for vertical-rl was broken. When accounting for flipped-blocks, we need to use the containing block writing-mode, instead of the direct parent. Static position doesn't really work cross writing modes in the existing layout system, so this isn't perfect, is closer to the old system. Bug: 635619 Change-Id: Ia7f8144cc1c9515b161bf3502c58fee66e59f3c3 Reviewed-on: https://chromium-review.googlesource.com/c/1315390 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Aleks Totic <atotic@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#605345}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .