commit | 0f66a1b2eed922f76f1dd13af6d76cf84f494d84 | [log] [tgz] |
---|---|---|
author | Charles Zhao <charleszhao@chromium.org> | Tue Dec 11 00:28:29 2018 |
committer | Charles . <charleszhao@chromium.org> | Tue Dec 11 00:28:29 2018 |
tree | 9fd2fd49ae987d4f330a7e484e39f2d41d8bf587 | |
parent | 174dd8467376c95dccae945eddea39611ac1c4c6 [diff] |
TabRanker: Fix Query time logging. TabRanker query time logging was landed in this cl: https://chromium-review.googlesource.com/c/chromium/src/+/1350445 TabManager::GetSortedLifecycleUnitsFromTabRanker() was created to bypass calls to TabManager::GetSortedLifecycleUnits() But this was wrong on two aspects: (1) TabManagerDelegate::LowMemoryKillImpl is still calling GetSortedLifecycleUnits(), so ChromeOS discards are all skipped. (2) TabManagerDelegate::Candidate is calling lifecycle_unit_->GetSortKey() for inferring sorting, Which means TabRanker model won't work for ChromeOS discards. The fix: (1) Change TabManager, TabLifecycleUnit back to their previous code, which were sorting LifecycleUnits by TabRanker when it's enabled. (2) Add TabActivityWatcher::LogOldestNTabFeatures() and call this function in TabManager::DiscardTab for query time logging. Bug: 911474 TBR=charleszhao@chromium.org (cherry picked from commit 6378752b810e6122744cefac544c8d84278dcc71) Change-Id: I103e8237cd96ea87667536b7b44b27fe8772abb4 Reviewed-on: https://chromium-review.googlesource.com/c/1360471 Reviewed-by: Christopher Morin <cmtm@google.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614623} Reviewed-on: https://chromium-review.googlesource.com/c/1370153 Reviewed-by: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#245} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .