| commit | 0f8184e7f322b8ab4b9a6f67e64e258cc92f2d20 | [log] [tgz] |
|---|---|---|
| author | Ben Pastene <bpastene@chromium.org> | Tue Oct 27 18:15:07 2020 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Oct 27 18:15:07 2020 |
| tree | ce4d5987f9748f42ed9f778aeed99af54a119bc5 | |
| parent | 11a162e505911c99dfa7fc57a635557b6fdf01db [diff] |
Make all local script tests have invalid results on non-zero exit code. This will make any local-script test that has no failures reported in its json still be a failure if it exits with a non-zero code. eg: This build is green despite webkit_lint exiting with a non-zero code https://ci.chromium.org/p/chromium/builders/try/linux-rel/518410? With this patch, that build no becomes red. eg: https://ci.chromium.org/swarming/task/4f4c52cbd3076910 Bug: 1108689 Change-Id: I4649af21c587e19869d0ec9c0753fae7a136f006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2476959 Reviewed-by: Dirk Pranke <dpranke@google.com> Reviewed-by: Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format --no-clang-format) to autoformat new code.