commit b83393d0f4038aeaf67f970a024d8101df7348d1
author Jeffrey Young <cowmoo@chromium.org> Thu May 12 23:12:00 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu May 12 23:12:00 2022
tree f2af509666dab207f7b9ce3271cb712913abfb25
parent 7cdef80a0f839019bcc5053ce6f81e082f20f1c5

Revert "[views] Eliminate OnWidgetClosing from NudgeWidgetObserver"

This reverts commit fe0287f4474f8b77ecc4efe40cedcb6691704a73.

Reason for revert: MSAN failure

https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/27901/overview?q=ExactID%3Aninja%3A%2F%2Fash%3Aash_unittests%2FAdaptiveChargingNudgeControllerTest.NudgeShowExactlyOnce+VHash%3Ab5761b05c7110eb2

Original change's description:
> [views] Eliminate OnWidgetClosing from NudgeWidgetObserver
>
> Favor OnWidgetDestroying over OnWidgetClosing. OnWidgetClosing is
> only called where a Widget is closed directly, it fails to catch
> the case when the system destroys the NativeWidget directly. This
> can result in UAFs in situations where the OS directly destroys
> the widget.
>
> OnWidgetDestroying will be called every time a widget is destroyed
> and should be used instead in most cases.
>
> Bug: 1240365
> Change-Id: I043635fcfcc9a52dd68b21f4f9c37539bc0d7f34
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3641295
> Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1002735}

Cq-Include-Trybots: luci.chromium.try:linux_chromium_chromeos_msan_rel_ng
Bug: 1240365
Change-Id: I69348c0efca1ffdd7362881489d2ee1b9631494f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3646362
Auto-Submit: Jeffrey Young <cowmoo@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Roman Arora <romanarora@google.com>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Roman Arora <romanarora@google.com>
Reviewed-by: Roman Arora <romanarora@google.com>
Cr-Commit-Position: refs/heads/main@{#1002911}