commit | 1009aff2d6d032b8a819b48409ffcea6f089323d | [log] [tgz] |
---|---|---|
author | Kouhei Ueno <kouhei@chromium.org> | Wed Oct 11 04:17:37 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Oct 11 04:17:37 2017 |
tree | 10024d7713dc4cc9a3a179998e4643ee6abf692c | |
parent | fb8d9d4ea889395b1ecbc43ba0d8ce3fa4bb5857 [diff] |
[ES6 modules] HRIM may return errored module until V8 forgets instantiation errors Today, we are in somewhat stale state where new module tree fetching algorithm [1][2] is partially applied. This CL (temporarily) disables an assert which exists in the final algorithm, but doesn't hold today. Specifically, the assert in HostResolveImportedModule (HRIM [3]) Step 7 currently doesn't hold, as the instantiation may have failed for a module script node, and current V8 implementation records the instantiation error as an error. See the attached test case for an example. [1] https://github.com/whatwg/html/pull/2991 [2] https://github.com/tc39/ecma262/pull/1006 [3] https://html.spec.whatwg.org/multipage/webappapis.html#hostresolveimportedmodule(referencingscriptormodule,-specifier) Test: external/wpt/html/semantics/scripting-1/the-script-element/module/instantiation-error-8.html Bug: 772750, 763597 Change-Id: Ida600598b658c74cdbda5937219f1e62a41f2a16 Reviewed-on: https://chromium-review.googlesource.com/708078 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#507888}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .