Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 1018943002: Update HttpServerProperties::*AlternateProtocol* interface. (Closed)

Created:
5 years, 9 months ago by Bence
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update HttpServerProperties::*AlternateProtocol* interface. * Rename SetAlternateProtocol, WasAlternateProtocolRecentlyBroken, ConfirmAlternateProtocol, ClearAlternateProtocol methods to *AlternativeService*. * Rename SetBrokenAlternateProtocol to MarkAlternativeServiceBroken. * Make MarkAlternativeServiceBroken, WasAlternativeServiceRecentlyBroken, and ConfirmAlternativeService take |alternative_service| instead of |origin|. * Make SetAlternativeService take |alternative_service| instead of separate |protocol|, |port| arguments. |alternative_service.host| is currently ignored. This CL does not rename SetAlternateProtocolProbabilityThreshold and GetAlternateProtocolProbabilityThreshold methods or alternate_protocol_probability_threshold_ members, that will come later. TBR=pauljensen@chromium.org BUG=392576 Committed: https://crrev.com/cacc0999aef4d12a2e32fc14f651a448a0b83a00 Cr-Commit-Position: refs/heads/master@{#321622}

Patch Set 1 #

Total comments: 16

Patch Set 2 : First round of comments. #

Patch Set 3 : Rebase. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -226 lines) Patch
M components/cronet/android/cronet_url_request_context_adapter.cc View 1 1 chunk +5 lines, -5 lines 1 comment Download
M components/cronet/android/url_request_context_adapter.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 2 10 chunks +45 lines, -28 lines 0 comments Download
M net/http/http_server_properties.h View 1 3 chunks +28 lines, -19 lines 0 comments Download
M net/http/http_server_properties_impl.h View 1 chunk +10 lines, -8 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 1 2 5 chunks +18 lines, -23 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 12 chunks +68 lines, -76 lines 0 comments Download
M net/http/http_server_properties_manager.h View 1 chunk +10 lines, -8 lines 0 comments Download
M net/http/http_server_properties_manager.cc View 2 chunks +18 lines, -18 lines 0 comments Download
M net/http/http_server_properties_manager_unittest.cc View 3 chunks +15 lines, -11 lines 0 comments Download
M net/http/http_stream_factory.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/quic/quic_stream_factory.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 3 chunks +11 lines, -9 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (6 generated)
Bence
Ryan: PTAL at the part separate from https://crrev.com/1014303002.
5 years, 9 months ago (2015-03-18 18:38:56 UTC) #2
Ryan Hamilton
Great cleanup. https://codereview.chromium.org/1018943002/diff/1/components/cronet/android/cronet_url_request_context_adapter.cc File components/cronet/android/cronet_url_request_context_adapter.cc (right): https://codereview.chromium.org/1018943002/diff/1/components/cronet/android/cronet_url_request_context_adapter.cc#newcode201 components/cronet/android/cronet_url_request_context_adapter.cc:201: net::AlternateProtocol::QUIC, quic_hint_host_port_pair.host(), I wonder if the host ...
5 years, 9 months ago (2015-03-18 22:55:43 UTC) #3
Bence
Thanks. https://codereview.chromium.org/1018943002/diff/1/components/cronet/android/cronet_url_request_context_adapter.cc File components/cronet/android/cronet_url_request_context_adapter.cc (right): https://codereview.chromium.org/1018943002/diff/1/components/cronet/android/cronet_url_request_context_adapter.cc#newcode201 components/cronet/android/cronet_url_request_context_adapter.cc:201: net::AlternateProtocol::QUIC, quic_hint_host_port_pair.host(), On 2015/03/18 22:55:42, Ryan Hamilton wrote: ...
5 years, 9 months ago (2015-03-19 12:45:40 UTC) #4
Bence
Ryan, PTAL. Rebased on https://crrev.com/1014303002.
5 years, 9 months ago (2015-03-20 00:32:25 UTC) #5
Ryan Hamilton
lgtm
5 years, 9 months ago (2015-03-20 03:32:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018943002/40001
5 years, 9 months ago (2015-03-20 11:31:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/51026)
5 years, 9 months ago (2015-03-20 11:38:14 UTC) #10
Bence
Paul, PTAL at components/cronet/android/*. Thanks.
5 years, 9 months ago (2015-03-20 11:42:09 UTC) #12
Bence
https://codereview.chromium.org/1018943002/diff/40001/components/cronet/android/cronet_url_request_context_adapter.cc File components/cronet/android/cronet_url_request_context_adapter.cc (right): https://codereview.chromium.org/1018943002/diff/40001/components/cronet/android/cronet_url_request_context_adapter.cc#newcode201 components/cronet/android/cronet_url_request_context_adapter.cc:201: net::AlternateProtocol::QUIC, "", Note: empty host string means default host, ...
5 years, 9 months ago (2015-03-20 13:46:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018943002/40001
5 years, 9 months ago (2015-03-20 20:18:29 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-20 20:22:37 UTC) #17
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/cacc0999aef4d12a2e32fc14f651a448a0b83a00 Cr-Commit-Position: refs/heads/master@{#321622}
5 years, 9 months ago (2015-03-20 20:23:15 UTC) #18
pauljensen
Why was this landed TBR?
5 years, 9 months ago (2015-03-23 01:01:08 UTC) #19
Bence
On 2015/03/23 01:01:08, pauljensen wrote: > Why was this landed TBR? Because this is an ...
5 years, 9 months ago (2015-03-23 11:37:09 UTC) #20
pauljensen
The cronet/ changes lgtm. This should not have been landed TBR. I discussed proper TBR ...
5 years, 9 months ago (2015-03-24 11:01:53 UTC) #21
Bence
5 years, 9 months ago (2015-03-24 11:53:15 UTC) #22
Message was sent while issue was closed.
On 2015/03/24 11:01:53, pauljensen wrote:
> The cronet/ changes lgtm.  This should not have been landed TBR.  I discussed
> proper TBR policy with Bence yesterday morning.  Here's a link:
>
http://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Reviewe...

Thanks, and I'm sorry about that.

Powered by Google App Engine
This is Rietveld 408576698