Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1029633002: Add test for canonical host alternative service. (Closed)

Created:
5 years, 9 months ago by Bence
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add test for canonical host alternative service. If a canonical server advertises an alternative service without an explicit hostname, or an alternative protocol, then it is implied that the same alternative service works on other hosts. This CL adds a test to verify that if SetAlternativeService is called with an empty host (denoting no explicit hostname in the alternative service advertisement), then GetAlternativeService(origin) returns alternative services with host == origin.host(). This will be important once HttpServerProperties starts storing alternative services with hostname to make sure current behavior is preserved. BUG=392576 Committed: https://crrev.com/0186dcd1238a84cfe71134ee24e3602ff0404af6 Cr-Commit-Position: refs/heads/master@{#321976}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M net/http/http_server_properties_impl_unittest.cc View 1 chunk +17 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
Bence
Ryan, PTAL. Thanks.
5 years, 9 months ago (2015-03-23 17:54:10 UTC) #2
Ryan Hamilton
lgtm https://codereview.chromium.org/1029633002/diff/1/net/http/http_server_properties_impl_unittest.cc File net/http/http_server_properties_impl_unittest.cc (right): https://codereview.chromium.org/1029633002/diff/1/net/http/http_server_properties_impl_unittest.cc#newcode461 net/http/http_server_properties_impl_unittest.cc:461: EXPECT_EQ(test_host_port_pair.host(), alternative_service.host); This is great! Nice. That being ...
5 years, 9 months ago (2015-03-23 20:48:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029633002/1
5 years, 9 months ago (2015-03-24 12:03:43 UTC) #5
Bence
On 2015/03/23 20:48:07, Ryan Hamilton wrote: > lgtm > > https://codereview.chromium.org/1029633002/diff/1/net/http/http_server_properties_impl_unittest.cc > File net/http/http_server_properties_impl_unittest.cc (right): ...
5 years, 9 months ago (2015-03-24 12:05:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 12:11:25 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 12:12:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0186dcd1238a84cfe71134ee24e3602ff0404af6
Cr-Commit-Position: refs/heads/master@{#321976}

Powered by Google App Engine
This is Rietveld 408576698