Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1067223002: Do not poison %FunctionPrototype%'s restricted properties (Closed)

Created:
5 years, 8 months ago by caitp (gmail)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not poison %FunctionPrototype%'s restricted properties In ES6, these properties of the intrinsic %FunctionPrototype% are poisoned during CreateIntrinsics() / AddRestrictedFunctionProperties(). It's unnecessary to poison them again, and testing whether they are a function or not causes tests to fail. BUG=v8:3982 R=arv@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/a5a386a2d335e09f80a4572f70001f4ecd4f0103

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
caitp (gmail)
PTAL --- anyone else who should look at this?
5 years, 8 months ago (2015-04-08 01:08:03 UTC) #1
arv (Not doing code reviews)
LGTM
5 years, 8 months ago (2015-04-08 01:28:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067223002/1
5 years, 8 months ago (2015-04-08 14:58:01 UTC) #5
caitp (gmail)
On 2015/04/08 14:58:01, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 8 months ago (2015-04-08 19:10:04 UTC) #6
arv (Not doing code reviews)
On 2015/04/08 19:10:04, caitp wrote: > On 2015/04/08 14:58:01, I haz the power (commit-bot) wrote: ...
5 years, 8 months ago (2015-04-08 19:15:37 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a5a386a2d335e09f80a4572f70001f4ecd4f0103 Cr-Commit-Position: refs/heads/master@{#324265}
5 years, 8 months ago (2015-04-08 19:18:23 UTC) #8
arv (Not doing code reviews)
5 years, 8 months ago (2015-04-08 19:18:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a5a386a2d335e09f80a4572f70001f4ecd4f0103 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698