commit 10a029e95216c568d9bba9714e52edd761cf9054
author ossu <ossu@webrtc.org> Tue Mar 01 08:41:31 2016
committer Commit bot <commit-bot@chromium.org> Tue Mar 01 08:41:39 2016
tree e9b3aae9ac07d3564422fa3c2382a12038e4999a
parent 22c2b4814ae69d230512eb93cc20771fcf38879b

Changed AudioEncoder::Encode to take an rtc::Buffer* instead of uint8_t* and a maximum size.

For backwards compatibility, I've added kept the old interface to
Encode() and EncodeInternal and created default implementations of both
variants of EncodeInternal(), each calling the other. At least one of
the variants must be implemented in a subclass or we'll run out of stack
and explode. Would be nice if we could catch that before runtime. :/

The new interface to EncodeInternal() is protected, since it should
never be called from the outside.

Was unable to mark the old EncodeInternal() as RTC_DEPRECATED, since the
default implementaion of the new variant needs to call it to work around
old implementations. The old Encode() variant is deprecated, at least.

Added a test for backwards compatibility in audio_encoder_unittest.cc.
For the added test I broke out MockEncodeHelper from
audio_encoder_copy_red_unittest.cc and renamed it MockAudioEncoderHelper.

Review URL: https://codereview.webrtc.org/1725143003

Cr-Commit-Position: refs/heads/master@{#11823}