commit | 10a2a27698c90e59642d117a53b054bfa0eb8f16 | [log] [tgz] |
---|---|---|
author | Jared Loucks <jaredloucks@google.com> | Thu Mar 25 00:41:26 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Mar 25 00:41:26 2021 |
tree | dbc095cd4db6e591ad02bcf84c4ba0bf32c2591e | |
parent | ba8e7ee1e361e1f23379a7febb93fb30c898dfa2 [diff] |
crosfleet: three small bug fixes These were certainly super hard to notice at first. Two are copy-paste goofs; the 'return nil' bug was probably done without thinking and then glossed over multiple times when I was tired. Change-Id: I35ca4726834ae26595c69c687de354aff69b4ad2 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2785483 Reviewed-by: Taylor Clark <taylormade@google.com> Commit-Queue: Jared Loucks <jaredloucks@google.com> Cr-Commit-Position: refs/heads/master@{#39703}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.