commit | 10b274b1e70a14ea1793ec6147e88c0780909b56 | [log] [tgz] |
---|---|---|
author | Garrett Beaty <gbeaty@chromium.org> | Tue Nov 10 15:00:12 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Nov 10 15:00:12 2020 |
tree | 401aa886d522a328a9fc197e29f1a39a0085e23c | |
parent | c431e040a30af5970f48bafd735e4c8e1c7b234b [diff] |
Configure the chromium_android module for all android builders. Curently, if an android builder does not specify an android config, it ends up causing an infra failure when it attempts to run chromium_android module code because the module has not been configured. With this change, the same condition gates whether to configure the chromium_android module and whether to call its code. It is not necessary to explicitly set the android config in a bot spec because the module has a root config which sets necessary values. The majority of configs for the module do not have any effect and should be cleaned up. Change-Id: I8afb7278173a253abc2bbeeeeee496a88f0fd74b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2525788 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*
), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores
, with the exception of the special functions RunSteps
and RunTests
in recipes. Use yapf (git cl format --no-clang-format
) to autoformat new code.