Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1214693007: [bindings] Support ArrayClass WebIDL attribute (Closed)

Created:
5 years, 5 months ago by caitp (gmail)
Modified:
5 years, 5 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Support ArrayClass WebIDL attribute This feature is no longer used for NodeList or HTMLCollection, however CSSOM and Geometry find uses for it. BUG=229398 LOG=N R=arv@chromium.org, haraken@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -35 lines) Patch
M Source/bindings/IDLExtendedAttributes.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/core/v8/V8PerContextData.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/core/v8/V8PerContextData.cpp View 4 chunks +15 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/WrapperTypeInfo.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/bindings/scripts/v8_interface.py View 2 chunks +8 lines, -0 lines 0 comments Download
M Source/bindings/templates/interface_base.cpp View 1 chunk +1 line, -2 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestListInterface.idl View 1 chunk +3 lines, -2 lines 0 comments Download
A + Source/bindings/tests/results/core/V8TestListInterface.h View 2 chunks +10 lines, -10 lines 0 comments Download
A + Source/bindings/tests/results/core/V8TestListInterface.cpp View 3 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
caitp (gmail)
Hi, PTAL some time if interested! Unfortunately, this doesn't seem to be needed for DOM ...
5 years, 5 months ago (2015-06-30 23:05:12 UTC) #1
haraken
Given that there is no use case or no planned use case, I'd say it's ...
5 years, 5 months ago (2015-06-30 23:52:12 UTC) #2
caitp (gmail)
On 2015/06/30 23:52:12, haraken wrote: > Given that there is no use case or no ...
5 years, 5 months ago (2015-07-01 00:18:11 UTC) #3
haraken
On 2015/07/01 00:18:11, caitp wrote: > On 2015/06/30 23:52:12, haraken wrote: > > Given that ...
5 years, 5 months ago (2015-07-01 00:21:23 UTC) #4
caitp (gmail)
On 2015/07/01 00:21:23, haraken wrote: > On 2015/07/01 00:18:11, caitp wrote: > > On 2015/06/30 ...
5 years, 5 months ago (2015-07-01 00:24:40 UTC) #5
jsbell
This thread makes me nervous: https://lists.w3.org/Archives/Public/public-script-coord/2014JulSep/0077.html Specifically, breaking Closure. i.e. we should track down what ...
5 years, 5 months ago (2015-07-01 17:51:09 UTC) #8
arv (Not doing code reviews)
On 2015/07/01 17:51:09, jsbell wrote: > Specifically, breaking Closure. i.e. we should track down what ...
5 years, 5 months ago (2015-07-01 18:02:42 UTC) #9
caitp (gmail)
5 years, 5 months ago (2015-07-16 14:06:31 UTC) #10
Cameron's spec renamed this to [LegacyArrayClass], so maybe it's been given up
on entirely in favour of Elements and iterable<>. Gonna close this one until
someone wants api compat with gecko for MediaList or DOMRectList

Powered by Google App Engine
This is Rietveld 408576698