Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1254523002: Temporarily disable ServiceWorkerVersionBrowserTest.FetchEvent_respondWithRejection (Closed)

Created:
5 years, 5 months ago by horo
Modified:
5 years, 5 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily disable ServiceWorkerVersionBrowserTest.FetchEvent_respondWithRejection https://codereview.chromium.org/1228233007/ will add another message. So this CL temporarily disables this test. 1/3 chromium: this cl. 2/3 blink: https://codereview.chromium.org/1228233007/ 3/3 chromium: https://codereview.chromium.org/1252503006/ BUG=505784 Committed: https://crrev.com/e613ce8f5f43100f4b973a0824fb3769e30890bb Cr-Commit-Position: refs/heads/master@{#340056}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
horo
falken@ Could you please review this?
5 years, 5 months ago (2015-07-23 02:31:02 UTC) #2
falken
On 2015/07/23 02:31:02, horo wrote: > falken@ > Could you please review this? lgtm
5 years, 5 months ago (2015-07-23 07:31:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254523002/1
5 years, 5 months ago (2015-07-23 08:00:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 08:24:06 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 08:24:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e613ce8f5f43100f4b973a0824fb3769e30890bb
Cr-Commit-Position: refs/heads/master@{#340056}

Powered by Google App Engine
This is Rietveld 408576698