Google Git
Sign in
chromium / chromium / src / bc687e2f6bf1e7beff2a49784342cb262590b23c
commitbc687e2f6bf1e7beff2a49784342cb262590b23c[log] [tgz]
authorAoyuan Zuo <zuoaoyuan@chromium.org>Thu Feb 15 22:15:02 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Feb 15 22:15:02 2024
treeca1cf881ea6d4fa683498e1e37e05ec9afffd724
parent8ada79adac3c2febb71688ccc055e2f3eb78b7e8 [diff]
[Event Timing] Expose interactionId to Keypress & keydown/up under composition

This CL changes the logic of generating interaction Id for keyboard
events in performance event timing.

Non-composition:
* Previous behaviour: Interaction id is generated on keyups, and will
  match the related keydown backwards.
* New behaviour: Interaction id is now generated on the keydown entry,
  and match forward with related keypress and keyup.
Composition(IME, virtual keyboard, etc.):
* Previous behaviour: Interaction id is assigned to each input event
  only.
* New behaviour: Interaction id is generated on the first input or
  keydown event (whichever comes first) before the compositionupdate,
  and any further keydown or input event before the compositionupdate
  and any number of keyups after compositionupdate will be matched
  with same interaction id.

This may affect the total duration of INP since more events are now
being meatured, eg. keypress.

Low-Coverage-Reason: OTHER This CL is also covered by wpt manual test.
Bug: 1456384
Change-Id: Ie736f3f189e9a349badbe03c4a65627ac491eff4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4632521
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Aoyuan Zuo <zuoaoyuan@chromium.org>
Reviewed-by: Michal Mocny <mmocny@chromium.org>
Reviewed-by: Aoyuan Zuo <zuoaoyuan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1261339}
11 files changed
tree: ca1cf881ea6d4fa683498e1e37e05ec9afffd724
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.