Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1263803002: Replace SpdyNameValueBlock typedef with SpdyHeaderBlock. (Closed)

Created:
5 years, 4 months ago by Bence
Modified:
5 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace SpdyNameValueBlock typedef with SpdyHeaderBlock. Replace SpdyNameValueBlock typedef with SpdyHeaderBlock. Use SpdyHeaderBlock typedef more widely. No behavior change intended. This CL is preparation for replacing SpdyHeaderBlock with an ordered datatype. Using the typedef in every place that currently explicitly uses map<string,string> will make this easier. Other cleanup: replacing NameValueBlock with HeaderBlock, as in every case this is being used to store headers. This CL lands server change 98865397 by rjshade. BUG=443287 Committed: https://crrev.com/1f79b119adb1926e21be8959c283b66a25c91fc1 Cr-Commit-Position: refs/heads/master@{#341101}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -217 lines) Patch
M net/quic/quic_headers_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_headers_stream_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/spdy/buffered_spdy_framer.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/spdy/fuzzing/hpack_example_generator.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/spdy/fuzzing/hpack_fuzz_util.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/spdy/fuzzing/hpack_fuzz_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/fuzzing/hpack_fuzz_util_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/hpack_decoder.h View 2 chunks +2 lines, -4 lines 0 comments Download
M net/spdy/hpack_decoder.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/spdy/hpack_decoder_test.cc View 8 chunks +20 lines, -23 lines 0 comments Download
M net/spdy/hpack_encoder.h View 2 chunks +4 lines, -5 lines 0 comments Download
M net/spdy/hpack_encoder.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/spdy/hpack_encoder_test.cc View 15 chunks +15 lines, -15 lines 0 comments Download
M net/spdy/hpack_round_trip_test.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M net/spdy/spdy_framer.h View 2 chunks +4 lines, -9 lines 0 comments Download
M net/spdy/spdy_framer.cc View 20 chunks +51 lines, -59 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 10 chunks +11 lines, -13 lines 0 comments Download
M net/spdy/spdy_protocol.h View 7 chunks +24 lines, -29 lines 0 comments Download
M net/spdy/spdy_protocol.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_test_util_common.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_test_util_common.cc View 8 chunks +20 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan, PTAL. Thanks.
5 years, 4 months ago (2015-07-29 19:37:35 UTC) #2
Ryan Hamilton
lgtm
5 years, 4 months ago (2015-07-29 22:42:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263803002/1
5 years, 4 months ago (2015-07-30 10:53:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-30 12:05:40 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 12:06:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f79b119adb1926e21be8959c283b66a25c91fc1
Cr-Commit-Position: refs/heads/master@{#341101}

Powered by Google App Engine
This is Rietveld 408576698