| commit | 12dffb33a2de8a3fc17851f2d4eceae457f4d721 | [log] [tgz] |
|---|---|---|
| author | Garrett Beaty <gbeaty@chromium.org> | Tue Mar 30 19:34:48 2021 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Mar 30 19:34:48 2021 |
| tree | c8089afdc7f7439f4f6e864f932fb34990441ef4 | |
| parent | f6697e6fd6617fea27a1f637f6fbc1cd7a8b30fc [diff] |
Use the builder spec when looking up bulder GN args. When looking up the builder GN args, there is at most one builder involved and the operation relies only on information that is present in the spec for that builder, so there is no need to create a bot config object. Additionally, the _chromium_config method is only used in that single spot and it's a small enough block of code to contain it directly at the callsite. Change-Id: I0da41c91b67cf4b0d7c244d5f67672ee5f9eb919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2795281 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format --no-clang-format) to autoformat new code.