commit | 130a5ae24a02daba8729ba2216bcaf3dbfacea69 | [log] [tgz] |
---|---|---|
author | Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> | Fri Feb 08 16:58:38 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Feb 08 16:58:38 2019 |
tree | 8ee786ce7f6eecd82f55b838a609cd26c5b55f29 | |
parent | b9c46de8f28afac43e46c37b48bf1d1378823f33 [diff] |
media::learning: Make LabelledExample's move assignment operator noexcept The GCC build is currently broken with an error like this: ../../media/learning/common/labelled_example.cc:20:1: error: function ‘media::learning::LabelledExample::LabelledExample(media::learning::LabelledExample&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’ LabelledExample::LabelledExample(LabelledExample&& rhs) noexcept = default; ^~~~~~~~~~~~~~~ With GCC, having that noexcept marker requires all members to be marked with noexcept themselves, and TargetValue was missing some assignment operators and noexcept markers. clang is fine because we pass -fno-exceptions and it disables the same error there, while GCC continues to raise it (bug 843143 and its corresponding CL have a longer discussion on this issue). Bug: 819294 Change-Id: Ide30932fc466ccb52d6883a82777e703dae48798 Reviewed-on: https://chromium-review.googlesource.com/c/1458210 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#630355}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .