| commit | 131f630e2cffdf9d7d4fc818c0f6eb6740c589c6 | [log] [tgz] |
|---|---|---|
| author | Darwin Huang <huangdarwin@chromium.org> | Tue Jan 15 00:30:31 2019 |
| committer | Commit Bot <commit-bot@chromium.org> | Tue Jan 15 00:30:31 2019 |
| tree | fb88e47810abd64406473c5e006babd68de39ea3 | |
| parent | 95372801cb4eb7102f9f9ac6001c9d2f60ae65c3 [diff] |
ImageEncoder: Make implicit cast explicit
- Implicit cast from size_t (uint_64_t) to wtf_size_t (uint_32_t) loses precision. Let's document this and make it clear.
../../third_party/blink/renderer/platform/image-encoders/image_encoder.h:26:48: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'WTF::wtf_size_t' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
dst_->Append((const unsigned char*)buffer, size);
~~~~~~ ^~~~
Bug: 896479
Change-Id: Iadedc5c3c4ed1de57cadcc2783a0eb42d64cbd76
Reviewed-on: https://chromium-review.googlesource.com/c/1409808
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622651}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .