Chromium Code Reviews

Issue 1410713006: Unreachable should call V8_Fatal on release builds instead of silently ignoring the error. (Closed)

Created:
5 years, 2 months ago by Hannes Payer (out of office)
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer, *jochen (gone - plz use gerrit)
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Unreachable should call V8_Fatal on release builds instead of silently ignoring the error. BUG= Committed: https://crrev.com/148e51b3f353563543294e57e92b3f58db588a07 Cr-Commit-Position: refs/heads/master@{#31397}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+1 line, -1 line)
M src/base/logging.h View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 8 (3 generated)
Benedikt Meurer
LGTM from my side, I prefer fail on error over self healing code. Adding jochen ...
5 years, 2 months ago (2015-10-20 05:34:06 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-10-20 06:06:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410713006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410713006/1
5 years, 2 months ago (2015-10-20 07:13:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 07:15:03 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 07:15:32 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/148e51b3f353563543294e57e92b3f58db588a07
Cr-Commit-Position: refs/heads/master@{#31397}

Powered by Google App Engine