Google Git
Sign in
chromium / chromium / src / 141f543682c748e5d6e5153dc3040d0eb1e815e2
commit141f543682c748e5d6e5153dc3040d0eb1e815e2[log] [tgz]
authorTom Anderson <thomasanderson@chromium.org>Tue Oct 03 16:54:46 2017
committerCommit Bot <commit-bot@chromium.org>Tue Oct 03 16:54:46 2017
tree70e5ee622f9cdad7c7a5d2049e84ff3fb6299061
parentb18507453f5b27f871d1f72e7d96d88ec2f82711 [diff]
Linux native notifications: Explicitly pass app_name and app_icon

The app_name and app_icon used to be passed implicitly via the desktop
file hint.  Some notification servers, including Cinnamon, do not look
at this hint.  For this reason, always explicitly pass them.

Also, Cinnamon now renders *both* a product logo and a notification
icon, and notifications can look like this:
https://bugs.chromium.org/p/chromium/issues/detail?id=676220#c93

BUG=676220
R=peter@chromium.org,thestig@chromium.org

Change-Id: I1fa63c793b51d642458a75bedd90bc1e512f6c8d
Reviewed-on: https://chromium-review.googlesource.com/690979
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506070}
1 file changed
tree: 70e5ee622f9cdad7c7a5d2049e84ff3fb6299061
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .