Google Git
Sign in
chromium / chromium / src / 17350d35a047286d79010e0abfea3d84722d3dc7
commit17350d35a047286d79010e0abfea3d84722d3dc7[log] [tgz]
authorpkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>Tue Jun 26 23:37:02 2012
committerpkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>Tue Jun 26 23:37:02 2012
tree273c226b2d0eebdbb287dc04f260c7541775b297
parentbd52a98b4ef0149a544c45a3dbf870ce3f384688 [diff]
Make SplitString() and variants clear their outparam vector.  (Note that SplitStringIntoKeyValues() and SplitStringIntoKeyValuePairs() already did this.)  This is more in line with what other APIs that take outparams do.

I audited all callers, and the only ones affected by this are the buggy ones in bug 134695 that already wanted this behavior, as well as the couple of places in this CL that were manually calling clear() and now don't have to.

BUG=134695
TEST=none
TBR=brettw,phajdan.jr
Review URL: https://chromiumcodereview.appspot.com/10684003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144323 0039d316-1c4b-4281-b951-d872f2087c98
5 files changed
tree: 273c226b2d0eebdbb287dc04f260c7541775b297
  1. ash/
  2. base/
  3. breakpad/
  4. build/
  5. chrome/
  6. chrome_frame/
  7. chromeos/
  8. cloud_print/
  9. content/
  10. courgette/
  11. crypto/
  12. dbus/
  13. google_update/
  14. gpu/
  15. ipc/
  16. jingle/
  17. media/
  18. native_client_sdk/
  19. net/
  20. ppapi/
  21. printing/
  22. remoting/
  23. rlz/
  24. sandbox/
  25. sdch/
  26. skia/
  27. sql/
  28. sync/
  29. testing/
  30. third_party/
  31. tools/
  32. ui/
  33. webkit/
  34. .DEPS.git
  35. .gitignore
  36. Android.mk
  37. AUTHORS
  38. codereview.settings
  39. DEPS
  40. LICENSE
  41. OWNERS
  42. PRESUBMIT.py
  43. WATCHLISTS