Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1455483002: Makes the default French keyboard as fr(oss) XKB layout. (Closed)

Created:
5 years, 1 month ago by Shu Chen
Modified:
5 years, 1 month ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes the default French keyboard as fr(oss) XKB layout. It would be risky to modify the id "xkb:fr::fra" to "xkb:fr:oss:fra", because it is in VPD. So this cl just modify the layout which is kind of hacky. This is the 2nd attempt for https://codereview.chromium.org/1436813009, which broke tests because it forgot to modify the whitelist for login layouts. BUG=409835 TEST=The french keyboard by default is "fr(oss)" layout and tests not fail as in crbug.com/555507. Committed: https://crrev.com/8601888a7b5768aa9f4b6074dd9a0693587e1617 Cr-Commit-Position: refs/heads/master@{#360051}

Patch Set 1 #

Patch Set 2 : rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/chromeos/component_extension_ime_manager.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Shu Chen
Nona, can you please help to review this cl? Thanks
5 years, 1 month ago (2015-11-17 08:24:44 UTC) #2
Seigo Nonaka
lgtm
5 years, 1 month ago (2015-11-17 08:42:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455483002/1
5 years, 1 month ago (2015-11-17 08:42:55 UTC) #7
commit-bot: I haz the power
Failed to apply patch for ui/base/ime/chromeos/component_extension_ime_manager.cc: While running git apply --index -3 -p1; error: patch ...
5 years, 1 month ago (2015-11-17 09:12:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455483002/20001
5 years, 1 month ago (2015-11-17 10:16:26 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-17 10:43:57 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 10:44:46 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8601888a7b5768aa9f4b6074dd9a0693587e1617
Cr-Commit-Position: refs/heads/master@{#360051}

Powered by Google App Engine
This is Rietveld 408576698