commit | 146bf5ff1885c11650da4b2eb711f1362e712dca | [log] [tgz] |
---|---|---|
author | Noel Gordon <noel@chromium.org> | Thu Jan 10 13:32:23 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jan 10 13:32:23 2019 |
tree | 94c699eba460d6cf5520f8cb1b66be3ce4fec36d | |
parent | bd6162e247c674a46da7a27db9331196ed0f7321 [diff] |
[ChromeOS] Remove webcal: and mailto: protocol handler i18n strings These i18n strings contain a URL, and the URLs do not change when they are translated i18n [1]. So there is no reason to define them in a grd <message> string. The URLs also contain the special character sequence %s which is an invalid i18n placeholder per issue 915681. To help resolve bug 915681, remove these IDS-defined URL from the .grd file and in-line the URLs where used instead. [1] Note that l10n_util::GetStringUTF8(IDS_XX) is allowed to re-format an IDS string for RTL locales if there is evidence that the string has RTL characters. These URL strings have no RTL characters, so they were identical in both LTR and RTL locales when translated. It is therefore safe to not use l10n_util::GetStringUTF8 to pre-process these URLs. No change in behavior, no new tests. Bug: 920577 Change-Id: Ib11576e2f2185f96f571300d120901d7c6578548 Reviewed-on: https://chromium-review.googlesource.com/c/1402388 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#621564}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .