Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1471683002: [StyleGuide] Allow begin and end non-member functions (Closed)

Created:
5 years, 1 month ago by Ruud van Asseldonk
Modified:
5 years, 1 month ago
Reviewers:
danakj, Nico
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org, Ryan Sleevi, brettw, dcheng, Jeffrey Yasskin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[StyleGuide] Allow begin and end non-member functions Allow usage of |std::begin| and |std::end|. This is useful for iterating fixed-size arrays. Discussion thread: https://groups.google.com/a/chromium.org/d/topic/cxx/5iFNE8P5qT4/discussion Furthermore, this CL replaces home-brewn |std::end|-like functions in base/trace_event with |std::end| to verify that <iterator> is supported on all platforms. Committed: https://crrev.com/b425288a3f4168d1813d7c4db83de3c801cd9365 Cr-Commit-Position: refs/heads/master@{#361192}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add link to discussion thread #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -32 lines) Patch
M base/trace_event/heap_profiler_allocation_context_tracker.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M base/trace_event/heap_profiler_allocation_context_tracker_unittest.cc View 2 chunks +6 lines, -11 lines 0 comments Download
M styleguide/c++/c++11.html View 1 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Ruud van Asseldonk
5 years, 1 month ago (2015-11-23 10:00:40 UTC) #2
Ruud van Asseldonk
5 years, 1 month ago (2015-11-23 16:24:53 UTC) #4
Nico
lgtm with comment addressed and green try jobs. thanks! https://codereview.chromium.org/1471683002/diff/1/styleguide/c++/c++11.html File styleguide/c++/c++11.html (right): https://codereview.chromium.org/1471683002/diff/1/styleguide/c++/c++11.html#newcode309 styleguide/c++/c++11.html:309: ...
5 years, 1 month ago (2015-11-23 16:27:51 UTC) #5
danakj
lgtm 2
5 years, 1 month ago (2015-11-23 18:54:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471683002/20001
5 years, 1 month ago (2015-11-23 19:00:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/132956)
5 years, 1 month ago (2015-11-23 20:44:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471683002/20001
5 years, 1 month ago (2015-11-23 20:56:33 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-23 21:47:10 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 21:47:52 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b425288a3f4168d1813d7c4db83de3c801cd9365
Cr-Commit-Position: refs/heads/master@{#361192}

Powered by Google App Engine
This is Rietveld 408576698