Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1517243002: [es6] Remove the %DefaultConstructorCallSuper intrinsic. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@GetSuperConstructor
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Remove the %DefaultConstructorCallSuper intrinsic. Instead desugar the default constructor for derived classes using the same mechanism we use for normal super constructor calls. TBR=rossberg@chromium.org R=mstarzinger@chromium.org Committed: https://crrev.com/d671f427fe8546c1af30b14809511474af2e4172 Cr-Commit-Position: refs/heads/master@{#32810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -490 lines) Patch
M src/ast/prettyprinter.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M src/parsing/parser.cc View 3 chunks +13 lines, -9 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +0 lines, -21 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (5 generated)
Benedikt Meurer
5 years ago (2015-12-11 15:58:24 UTC) #1
Benedikt Meurer
Hey Michi, Removing all the weird code. Please take a look. Thanks, Benedikt
5 years ago (2015-12-11 15:58:52 UTC) #2
Michael Starzinger
LGTM. Love it!
5 years ago (2015-12-11 16:02:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517243002/1
5 years ago (2015-12-11 16:02:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 16:38:52 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d671f427fe8546c1af30b14809511474af2e4172 Cr-Commit-Position: refs/heads/master@{#32810}
5 years ago (2015-12-11 16:39:07 UTC) #10
adamk
drive-by lgtm, just wanted to say this change is great.
5 years ago (2015-12-11 19:22:31 UTC) #12
Benedikt Meurer
5 years ago (2015-12-11 21:00:12 UTC) #13
Message was sent while issue was closed.
On 2015/12/11 19:22:31, adamk wrote:
> drive-by lgtm, just wanted to say this change is great.

Thanks Adam.

Powered by Google App Engine
This is Rietveld 408576698